On Tuesday, 2018-02-27 12:30:48 -0800, Eric Anholt wrote:
> Dylan Baker <dylan@xxxxxxxxxxxxx> writes:
>
> > [ Unknown signature status ]
> > Quoting Eric Engestrom (2018-02-27 03:11:07)
> >> The message block printed is the same as the one in configure.ac
> >>
> >> Signed-off-by: Eric Engestrom <eric.engestrom@xxxxxxxxxx>
> >> ---
> >> meson.build | 17 +++++++++++++++++
> >> 1 file changed, 17 insertions(+)
> >>
> >> diff --git a/meson.build b/meson.build
> >> index bd00cdc2cae9f0749180..ab6f881755935968b822 100644
> >> --- a/meson.build
> >> +++ b/meson.build
> >> @@ -373,3 +373,20 @@ if with_man_pages
> >> endif
> >> subdir('data')
> >> subdir('tests')
> >> +
> >> +message('')
> >> +message('@0@ will be compiled with:'.format(meson.project_name()))
> >> +message('')
> >> +message(' libkms @0@'.format(with_libkms))
> >> +message(' Intel API @0@'.format(with_intel))
> >> +message(' vmwgfx API @0@'.format(with_vmwgfx))
> >> +message(' Radeon API @0@'.format(with_radeon))
> >> +message(' AMDGPU API @0@'.format(with_amdgpu))
> >> +message(' Nouveau API @0@'.format(with_nouveau))
> >> +message(' OMAP API @0@'.format(with_omap))
> >> +message(' EXYNOS API @0@'.format(with_exynos))
> >> +message(' Freedreno API @0@ (kgsl: @1@)'.format(with_freedreno, with_freedreno_kgsl))
> >> +message(' Tegra API @0@'.format(with_tegra))
> >> +message(' VC4 API @0@'.format(with_vc4))
> >> +message(' Etnaviv API @0@'.format(with_etnaviv))
> >> +message('')
> >> --
> >> Cheers,
> >> Eric
> >>
> >
> > This one is certainly simple enough that we can use a single message call and a
> > ''' string :)
>
> But then you end up with 13 @n@ values and when someone wants to put
> something earlier in the list for some sorting reason, then they need to
> renumber the rest. This is much nicer.
I have to agree here. Dylan, why did you want to avoid multiple
`message()`? They're not expensive afaict, so I'm not sure what the gain
would be?
I also had a try, and multiline messages only get a `Message:` prefix on
the first line, so combining them would result in unpredictable vertical
alignments. Unless there's a good reason to merge them, I'll keep them
separate.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
