On 27/02/18 13:28, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Monday, 12 February 2018 11:44:31 EET Tomi Valkeinen wrote: >> If we have no crtcs/connectors, fbdev init goes fine, but >> omap_fbdev_create() is never called. This means that omap_fbdev->bo is >> NULL and omap_fbdev_free() crashes. >> >> Add a check to omap_fbdev_free() to handle the NULL case. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxx> > > I wonder whether we shouldn't fail probe if we have no CRTC or connector, but > regardless of that, this change looks good to me. We can use the writeback without any displays. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
