Re: [CI] drm/mm: Fix caching of leftmost node in the interval tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Christian König (2018-02-20 09:45:54)
> Am 20.02.2018 um 10:37 schrieb Chris Wilson:
> > When we descend the tree to find our slot, if we step to the right, we
> > are no longer the leftmost node.
> >
> > Fixes: f808c13fd373 ("lib/interval_tree: fast overlap detection")
> > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> > Cc: Davidlohr Bueso <dbueso@xxxxxxx>
> > Cc: Jérôme Glisse <jglisse@xxxxxxxxxx>
> > Cc: Christian König <christian.koenig@xxxxxxx>
> > Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
> 
> Acked-by: Christian König <christian.koenig@xxxxxxx> for now.
> 
> But I agree with Joonas that we should think about using 
> rb_insert_augmented instead when we actually don't use the extra 
> functionality.

The cost is having to reimplement interval_tree_generic.h. Not too
onerous, but trickier than fixing leftmost here. :)
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux