Re: [PATCH libdrm] configure.ac: pthread-stubs not present on OpenBSD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 20, 2018 at 12:18:45PM +0000, Eric Engestrom wrote:
> On Tuesday, 2018-02-20 22:23:41 +1100, Jonathan Gray wrote:
> > On Tue, Feb 20, 2018 at 10:21:38AM +0000, Eric Engestrom wrote:
> > > On Tuesday, 2018-02-20 17:09:14 +1100, Jonathan Gray wrote:
> > > > pthread-stubs is no longer required on OpenBSD and has been removed.
> > > > libpthread parts involved moved to libc.
> > > 
> > > Great news!
> > > Reviewed-by: Eric Engestrom <eric.engestrom@xxxxxxxxxx>
> > > 
> > > Note that meson needs the same change:
> > > ----8<----
> > > diff --git a/meson.build b/meson.build
> > > index d600a906948c0e680885..bd00cdc2cae9f0749180 100644
> > > --- a/meson.build
> > > +++ b/meson.build
> > > @@ -35,8 +35,7 @@ with_install_tests = get_option('install-test-programs')
> > >  
> > >  config = configuration_data()
> > >  
> > > -# TODO: openbsd is guess, the others are correct
> > > -if ['freebsd', 'dragonfly', 'netbsd', 'openbsd'].contains(host_machine.system())
> > > +if ['freebsd', 'dragonfly', 'netbsd'].contains(host_machine.system())
> > >    dep_pthread_stubs = dependency('pthread-stubs', version : '>= 0.4')
> > >  else
> > >    dep_pthread_stubs = []
> > > ---->8----
> > > 
> > > Do you have commit access, or do you want me to push this for you?
> > > No need to send a v2, I'll add the meson bit when I push it, or you can
> > > add it if you push it yourself.
> > 
> > An almost identical patch was sent to the Mesa list.  I don't have
> > commit access to either repository so if you could push it that would be
> > great.
> 
> Saw it and it is also r-b'ed; I'll push them later today :)
> 
> > 
> > We can't take a build dependency on python for the xserver and related
> > parts in OpenBSD so I have no interest in meson and very much hope
> > autoconf remains otherwise it is back to writing custom makefiles for
> > everything.
> 
> Hmm, the idea was to get rid of autotools when the meson.build files
> have been tested enough, which sounds like it will be an issue for you.
> 
> What exactly is the blocker to using Meson on your side? Is it something
> that just needs a bit of work, or something that can't be done because of
> external factors (eg. some "scripting languages are not allowed" rule)?
> You mention python, would a Meson implementation in an other language be
> better for you guys?

It has been mentioned in several places at various times by
Matthieu Herrb, Mark Kettenis and myself.

ie
https://lists.x.org/archives/xorg-devel/2018-February/055807.html
https://lists.x.org/archives/xorg-devel/2017-March/053195.html
https://lists.freedesktop.org/archives/dri-devel/2017-March/135935.html

The OpenBSD src and xenocara trees need to be self-contained.  For
autotools we can regenerate files after import and not have a build time
dependency on gnu tools or ports.

Even if there was a C or perl implementation of meson under a suitable
license (not apache 2.0) it would still have to be integrated into a
make based build.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux