Eric Engestrom <eric.engestrom@xxxxxxxxxx> writes:
> Can be simplified a bit:
>
> _xlib_lease = get_option('xlib-lease')
> if _xlib_lease == 'auto'
> with_xlib_lease = with_platform_x11 and with_platform_display
> else
> with_xlib_lease = _xlib_lease == 'true'
> endif
>
> (We also usually try to avoid changing the type of a var, and meson might
> start being more strict with types in future releases)
I wondered about that in the places I copied my code from. Good to know
there's a better practice. I've switched to using this form.
>> +if with_xlib_lease
>> + vulkan_wsi_deps += dep_xcb_xrandr
>> + vulkan_wsi_args += [
>> + '-DVK_USE_PLATFORM_XLIB_XRANDR_EXT',
>> + ]
>
> vulkan_wsi_args += '-DVK_USE_PLATFORM_XLIB_XRANDR_EXT'
I switched all of the inappropriate usage to this form for six separate
patches (three each for core/anv/radv by two extensions (DISPLAY and XLIB_XRANDR).
> with that, the meson part of this is
> Reviewed-by: Eric Engestrom <eric.engestrom@xxxxxxxxxx>
Awesome!
Thanks for reviewing the build system bits; I'm just starting to use
meson and every new change is a learning opportunity at this point.
--
-keith
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
