On Thu, Nov 17, 2011 at 11:06 AM, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote: > On Thu, 17 Nov 2011 00:20:44 +0200 > Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > >> On Wed, Nov 16, 2011 at 01:23:01PM -0800, Jesse Barnes wrote: >> > On Wed, 16 Nov 2011 23:19:38 +0200 >> > Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> wrote: >> > > Oh and one extra detail just occured to me regarding the three plane >> > > formats. Should we even define formats for both the YUV vs. YVU >> > > variant. Seeing as we now have independent handles and offsets for >> > > each plane, we can make do with just one format definition. >> > >> > Don't you still need to know the order? I.e. what's in handle[1], U or >> > V? >> >> We could define it so that handle[1] is always Cb and handle [2] is Cr, >> for example. Then it's up to user space to set the handles orrectly, >> which it has to do anyway. > > Yeah see my other mail; I'm mainly worried about single bo cases. well, you do still have an offset per-plane.. so single bo case: cmd->handles[0] = bo; cmd->offsets[0] = 0; cmd->handles[1] = bo; cmd->offsets[1] = u_offset; cmd->handles[2] = bo; cmd->offsets[2] = v_offset; nothing says that you can't have u_offset > v_offset BR, -R > -- > Jesse Barnes, Intel Open Source Technology Center > > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > http://lists.freedesktop.org/mailman/listinfo/dri-devel > > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
