On Wed, Jan 31, 2018 at 11:03 AM, John Stultz <john.stultz@xxxxxxxxxx> wrote: > On Wed, Jan 31, 2018 at 10:51 AM, Alexandru-Cosmin Gheorghe > <Alexandru-Cosmin.Gheorghe@xxxxxxx> wrote: >> It seems that we don't pass any explicit fences to the kernel for >> IN_FENCE_FD property. This particular line seems wrong. >> >> @@ -593,14 +594,17 @@ int >> DrmDisplayCompositor::CommitFrame(DrmDisplayComposition *display_comp, >> else >> rotation |= DRM_MODE_ROTATE_0; >> >> - if (fence_fd < 0) { >> + if (fence_fd >= 0) { > > I'll give that a whirl. So I did give that a whirl after you suggested it, but it ended up causing nothing to be displayed, and I unfortunately didn't have time right then to dig much further. Rob however re-found this issue today, and I've been digging a bit more. At least with the HiKey board, it seem the trouble is when the IN_FENCE_FD is added to the pset, the atomic commit calls start to fail. I dug in and it seems we're catching in the kernel on the if (file->f_op != &sync_file_fops) check in sync_file_fdget(). I'm now trying to trace back to where the in fence was provided from to see what might be going wrong there. Curious if this is anything you ran across in your attempts? thanks -john _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel