On 07/02/18 16:11, Jyri Sarha wrote: > Since v2: > - Simplify dispc_mgr_has_framedone() > - dispc_hw_to_api_irq() and dispc_api_to_hw_irq() use new dispc_irq_bits[] > - rename dispc_ops read_irqstatus() to read_and_clear_irqstatus() and remove > clearmask > - precalculate priv->irq_uf_mask in omap_drm_irq_install() and use it in > omap_irq_fifo_underflow() Can you run these through checkpatch? There was at least one issue that needs to be fixed: WARNING: static const char * array should probably be static const char * const Other than the small comments I sent, I think it looks good. Laurent, do you have any objections? I think we probably will change the design later on how the irqs are handled (possibly move the irq handling code away from the common parts), but I think this cleans up things nicely for the time being. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
