Hi Maruthi,
FYI, the error/warning still remains.
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next
head: 987aae1f47ba0fe5a320d013d2bf97b5f9922761
commit: 4ab7d004f9ff2e877caa267887360e1804b4edcf [85/381] ASoC: AMD: enable ACP3x drivers build
config: tile-allyesconfig (attached as .config)
compiler: tilegx-linux-gcc (GCC) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 4ab7d004f9ff2e877caa267887360e1804b4edcf
# save the attached .config to linux build tree
make.cross ARCH=tile
All errors (new ones prefixed by >>):
In file included from sound/soc//amd/raven/acp3x-pcm-dma.c:26:0:
sound/soc//amd/raven/acp3x.h: In function 'rv_readl':
sound/soc//amd/raven/acp3x.h:28:9: error: implicit declaration of function 'readl'; did you mean 'vread'? [-Werror=implicit-function-declaration]
return readl(base_addr - ACP3x_PHY_BASE_ADDRESS);
^~~~~
vread
sound/soc//amd/raven/acp3x.h: In function 'rv_writel':
sound/soc//amd/raven/acp3x.h:33:2: error: implicit declaration of function 'writel'; did you mean 'vwrite'? [-Werror=implicit-function-declaration]
writel(val, base_addr - ACP3x_PHY_BASE_ADDRESS);
^~~~~~
vwrite
sound/soc//amd/raven/acp3x-pcm-dma.c: In function 'config_acp3x_dma':
>> sound/soc//amd/raven/acp3x-pcm-dma.c:246:10: error: implicit declaration of function 'page_to_phys'; did you mean 'page_to_pfn'? [-Werror=implicit-function-declaration]
addr = page_to_phys(pg);
^~~~~~~~~~~~
page_to_pfn
sound/soc//amd/raven/acp3x-pcm-dma.c: In function 'acp3x_audio_probe':
sound/soc//amd/raven/acp3x-pcm-dma.c:638:22: error: implicit declaration of function 'devm_ioremap'; did you mean 'devm_kmemdup'? [-Werror=implicit-function-declaration]
adata->acp3x_base = devm_ioremap(&pdev->dev, res->start,
^~~~~~~~~~~~
devm_kmemdup
sound/soc//amd/raven/acp3x-pcm-dma.c:638:20: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
adata->acp3x_base = devm_ioremap(&pdev->dev, res->start,
^
cc1: some warnings being treated as errors
vim +246 sound/soc//amd/raven/acp3x-pcm-dma.c
090795ff Maruthi Srinivas Bayyavarapu 2017-03-30 222
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 223 static void config_acp3x_dma(struct i2s_stream_instance *rtd, int direction)
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 224 {
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 225 u16 page_idx;
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 226 u64 addr;
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 227 u32 low, high, val, acp_fifo_addr;
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 228 struct page *pg = rtd->pg;
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 229
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 230 /* 8 scratch registers used to map one 64 bit address.
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 231 * For 2 pages (4096 * 2 bytes), it will be 16 registers.
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 232 */
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 233 if (direction == SNDRV_PCM_STREAM_PLAYBACK)
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 234 val = 0;
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 235 else
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 236 val = 16;
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 237
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 238 /* Group Enable */
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 239 rv_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp3x_base +
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 240 mmACPAXI2AXI_ATU_BASE_ADDR_GRP_1);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 241 rv_writel(PAGE_SIZE_4K_ENABLE, rtd->acp3x_base +
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 242 mmACPAXI2AXI_ATU_PAGE_SIZE_GRP_1);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 243
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 244 for (page_idx = 0; page_idx < rtd->num_pages; page_idx++) {
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 245 /* Load the low address of page int ACP SRAM through SRBM */
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 @246 addr = page_to_phys(pg);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 247 low = lower_32_bits(addr);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 248 high = upper_32_bits(addr);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 249
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 250 rv_writel(low, rtd->acp3x_base + mmACP_SCRATCH_REG_0 + val);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 251 high |= BIT(31);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 252 rv_writel(high, rtd->acp3x_base + mmACP_SCRATCH_REG_0 + val
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 253 + 4);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 254 /* Move to next physically contiguos page */
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 255 val += 8;
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 256 pg++;
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 257 }
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 258
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 259 if (direction == SNDRV_PCM_STREAM_PLAYBACK) {
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 260 /* Config ringbuffer */
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 261 rv_writel(MEM_WINDOW_START, rtd->acp3x_base +
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 262 mmACP_BT_TX_RINGBUFADDR);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 263 rv_writel(MAX_BUFFER, rtd->acp3x_base +
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 264 mmACP_BT_TX_RINGBUFSIZE);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 265 rv_writel(0x40, rtd->acp3x_base + mmACP_BT_TX_DMA_SIZE);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 266
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 267 /* Config audio fifo */
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 268 acp_fifo_addr = ACP_SRAM_PTE_OFFSET + (rtd->num_pages * 8)
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 269 + 1024;
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 270 rv_writel(acp_fifo_addr, rtd->acp3x_base +
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 271 mmACP_BT_TX_FIFOADDR);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 272 rv_writel(256, rtd->acp3x_base + mmACP_BT_TX_FIFOSIZE);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 273 rv_writel(PLAYBACK_MIN_PERIOD_SIZE, rtd->acp3x_base +
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 274 mmACP_BT_TX_INTR_WATERMARK_SIZE);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 275 } else {
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 276 /* Config ringbuffer */
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 277 rv_writel(MEM_WINDOW_START + MAX_BUFFER, rtd->acp3x_base +
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 278 mmACP_BT_RX_RINGBUFADDR);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 279 rv_writel(MAX_BUFFER, rtd->acp3x_base +
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 280 mmACP_BT_RX_RINGBUFSIZE);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 281 rv_writel(0x40, rtd->acp3x_base + mmACP_BT_RX_DMA_SIZE);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 282
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 283 /* Config audio fifo */
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 284 acp_fifo_addr = ACP_SRAM_PTE_OFFSET +
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 285 (rtd->num_pages * 8) + 1024 + 256;
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 286 rv_writel(acp_fifo_addr, rtd->acp3x_base +
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 287 mmACP_BT_RX_FIFOADDR);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 288 rv_writel(256, rtd->acp3x_base + mmACP_BT_RX_FIFOSIZE);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 289 rv_writel(CAPTURE_MIN_PERIOD_SIZE, rtd->acp3x_base +
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 290 mmACP_BT_RX_INTR_WATERMARK_SIZE);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 291 }
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 292
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 293 /* Enable watermark/period interrupt to host */
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 294 rv_writel(BIT(BT_TX_THRESHOLD) | BIT(BT_RX_THRESHOLD),
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 295 rtd->acp3x_base + mmACP_EXTERNAL_INTR_CNTL);
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 296 }
41456703 Maruthi Srinivas Bayyavarapu 2017-03-29 297
:::::: The code at line 246 was first introduced by commit
:::::: 4145670362d74c2406ffab0b5c59b7e7b4ce0dce ASoC: AMD: add ACP3x PCM driver DMA ops
:::::: TO: Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@xxxxxxx>
:::::: CC: Alex Deucher <alexander.deucher@xxxxxxx>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
