On Sun, 2011-11-13 at 09:57 +0100, Christian Schmidt wrote: > The current logic misunderstands the spec about CEA 18byte descriptors. > First, the spec doesn't state "detailed timing descriptors" but "18 byte > descriptors", so any data record could be stored, mixed timings and > other data, just as in the standard EDID. I don't think the code misinterprets this. But I also don't think your patch changes this interpretation, so that's fine. > Second, the lower four bit of byte 3 of the CEA record do not contain > the number of descriptors, but "the total number of DTDs defining native > formats in the whole EDID [...], starting with the first DTD in the DTD > list (which starts in the base EDID block)." A device can of course > support non-native formats. > > As such the number can't be used to determine n, and the existing code > will filter non-timing 18byte descriptors anyway. Good catch, thanks. Reviewed-by: Adam Jackson <ajax@xxxxxxxxxx> - ajax
Attachment:
signature.asc
Description: This is a digitally signed message part
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
