On Tue, Jan 30, 2018 at 10:09:27AM -0500, Sean Paul wrote: > On Tue, Jan 30, 2018 at 04:05:28AM -0600, Gustavo A. R. Silva wrote: > > Assign true or false to boolean variables instead of an integer value. > > > > This issue was detected with the help of Coccinelle. > > I suppose you could also fix up the other preferred assignment by adding !! > to the bitwise & operation. Assigning >1 to a bool is well defined. No need to clutter the code with !! imo. > > It's also helpful to post the spatch in the commit message so others can > replicate your result (this case is pretty trivial, so less important). > > Sean > > > > > Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx> > > --- > > Changes in v2: > > - Use true for boolean value in add_detailed_mode as suggested by Daniel > > Vetter. > > - Update subject. > > > > drivers/gpu/drm/drm_edid.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > > index ddd5379..b1cb262 100644 > > --- a/drivers/gpu/drm/drm_edid.c > > +++ b/drivers/gpu/drm/drm_edid.c > > @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) > > > > drm_mode_probed_add(closure->connector, newmode); > > closure->modes++; > > - closure->preferred = 0; > > + closure->preferred = false; > > } > > } > > > > @@ -2784,7 +2784,7 @@ add_detailed_modes(struct drm_connector *connector, struct edid *edid, > > struct detailed_mode_closure closure = { > > .connector = connector, > > .edid = edid, > > - .preferred = 1, > > + .preferred = true, > > .quirks = quirks, > > }; > > > > -- > > 2.7.4 > > > > -- > Sean Paul, Software Engineer, Google / Chromium OS > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel