Re: [PATCH libdrm 1/7] meson, configure: add warning when using undefined preprocessor tokens

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26 January 2018 at 11:30, Eric Engestrom <eric.engestrom@xxxxxxxxxx> wrote:
> Signed-off-by: Eric Engestrom <eric.engestrom@xxxxxxxxxx>
> ---
>  configure.ac | 2 +-
>  meson.build  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 35378b3384290f8e1e26..3fc4e7794cd974171c0a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -197,7 +197,7 @@ dnl skipped and all flags rechecked.  So there's no need to do anything
>  dnl else.  If for any reason you need to force a recheck, just change
>  dnl MAYBE_WARN in an ignorable way (like adding whitespace)
>
> -MAYBE_WARN="-Wall -Wextra \
> +MAYBE_WARN="-Wall -Wextra -Wundef \
>  -Wsign-compare -Werror-implicit-function-declaration \
>  -Wpointer-arith -Wwrite-strings -Wstrict-prototypes \
>  -Wmissing-prototypes -Wmissing-declarations -Wnested-externs \
> diff --git a/meson.build b/meson.build
> index d7a50cf96f905b53d37a..a410627fbf16a2c6d748 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -203,7 +203,7 @@ if cc.has_function('open_memstream')
>  endif
>
>  warn_c_args = []
> -foreach a : ['-Wall', '-Wextra', '-Wsign-compare',
> +foreach a : ['-Wall', '-Wextra', '-Wsign-compare', '-Wundef',

Unless we have [m]any undef warnings, I'd just make that Werror=undef,
across build systems.

-Emil
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux