Re: 'buf' pointer in ttm_bo_vm_access_kmap()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 26/01/18 09:38 AM, Christian König wrote:
Am 26.01.2018 um 15:31 schrieb Tom St Denis:
Hi all,

In the function ttm_bo_vm_access_kmap() it doesn't seem to me like the 'buf' pointer is incremented.  That seems like a bug no?

Yeah, looks suspicious to me as well. But TTM questions should CC the dri list as well.

And in this particular case I think Felix was the author that function.


Hi Christian,

I'm authoring a set of mostly NFC patches for TTM and already crafted a fix for this in the process.

If the fix (which is literally "buf += bytes" at the end of the while loop) doesn't get NAK'ed I'll submit it as part of my cleanup patches.

Cheers,
Tom
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux