Hi, On Sun, Dec 17, 2017 at 02:17:24AM +0200, Laurent Pinchart wrote: > +static const struct drm_prop_enum_list colorkey_modes[] = { > + { 0, "disabled" }, > + { 1, "source" }, > +}; > + > int rcar_du_vsp_init(struct rcar_du_vsp *vsp, struct device_node *np, > unsigned int crtcs) > { > @@ -441,6 +453,10 @@ int rcar_du_vsp_init(struct rcar_du_vsp *vsp, struct device_node *np, > rcdu->props.alpha, 255); > drm_plane_create_zpos_property(&plane->plane, 1, 1, > vsp->num_planes - 1); > + drm_plane_create_colorkey_properties(&plane->plane, > + colorkey_modes, > + ARRAY_SIZE(colorkey_modes), > + true); You seem to define the same list in your enumeration between your patch 2 and this one. Can this be something made generic too? Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel