Re: [PATCH 1/5] drm: rename {drm_clflush_sg, drm_clflush_pages}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 24, 2018 at 1:14 AM, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote:
Quoting Gurchetan Singh (2018-01-24 02:55:30)
> Since clfush is an x86-only instruction, these function names won't
> make much sense if we start adding cases for other architectures.

Whatever your dislike for the name, it has one clear advantage over the
new one: it tells you what it is flushing.
-Chris

What do you suggest, if one wants to flush vgem pages on ARM architecture?  Should we have a drm_clflush_pages(..) and a drm_arm_flush_pages(..), separated by #ifdef statements?
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux