Re: [PATCH] dma-buf: fix reservation_object_wait_timeout_rcu once more

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 22.01.2018 um 20:42 schrieb Lyude Paul:
Could you please make sure to add Cc: stable@xxxxxxxxxxxxxxx for this?
Sure, just pushed into our upstream branch.

Alex can you pick that up for your next drm-fixes pull request?

Sorry for the noise,
Christian.

  This is
causing crashing of wayland sessions on Fedora so we should definitely get
this into stable.

Other then that:

Tested-by: Lyude Paul <lyude@xxxxxxxxxx>
Reviewed-by: Lyude Paul <lyude@xxxxxxxxxx>

On Mon, 2018-01-22 at 20:32 +0100, Christian König wrote:
We need to set shared_count even if we already have a fence to wait for.

Signed-off-by: Christian König <christian.koenig@xxxxxxx>
---
  drivers/dma-buf/reservation.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/dma-buf/reservation.c b/drivers/dma-buf/reservation.c
index 461afa9febd4..649c0cebf5b1 100644
--- a/drivers/dma-buf/reservation.c
+++ b/drivers/dma-buf/reservation.c
@@ -506,14 +506,14 @@ long reservation_object_wait_timeout_rcu(struct
reservation_object *obj,
  		fence = NULL;
  	}
- if (!fence && wait_all) {
+	if (wait_all) {
  		struct reservation_object_list *fobj =
  						rcu_dereference(obj-
fence);
if (fobj)
  			shared_count = fobj->shared_count;
- for (i = 0; i < shared_count; ++i) {
+		for (i = 0; !fence && i < shared_count; ++i) {
  			struct dma_fence *lfence = rcu_dereference(fobj-
shared[i]);
if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT,

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux