Re: [PATCH v3 2/8] drm: xlnx: Xilinx DRM KMS driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 15, 2018 at 05:57:05PM -0800, Hyun Kwon wrote:
> +static struct drm_driver xlnx_drm_driver = {
> +       .driver_features                = DRIVER_MODESET | DRIVER_GEM |
> +                                         DRIVER_ATOMIC | DRIVER_PRIME,
> +       .lastclose                      = xlnx_lastclose,
> +
> +       .enable_vblank                  = xlnx_enable_vblank,
> +       .disable_vblank                 = xlnx_disable_vblank,

I thought I've mentioned this already: Please don't use these hooks,
they're deprecated. Instead use the ones in drm_crtc_funcs (that should
also reduce the need for a bit of casting and indirection you have going
on).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux