Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 8, 2011 at 9:18 PM, Jesse Barnes <jbarnes@xxxxxxxxxxxxxxxx> wrote:
> To properly support the various plane formats supported by different
> hardware, the kernel must know the pixel format of a framebuffer object.
> So add a new ioctl taking a format argument corresponding to a fourcc
> name from videodev2.h.  Implement the fb creation hooks in terms of the
> new mode_fb_cmd2 using helpers where the old bpp/depth values are
> needed.

I'm nearly sure I said this before, but please move the FOURCC defines
somewhere generic,
then use those, otherwise this is going to encourage crappy userspace
coding where
they drag in libv4l2 just to use a drm feature.

I know they are generic, but userspace writes will start to include
v4l headers to get at
the same defines you use in the kernel.

Dave.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux