Quoting Hans de Goede (2018-01-15 15:56:26)
> Hi,
>
> On 15-01-18 16:48, Chris Wilson wrote:
> > Commit 404d1a3edc38 ("drm: Add panel orientation quirks, v6.")
> > introduced a new internal Kconfig option for DRM and placed in the
> > middle of the DRM option sequence without including a depends on DRM.
> > This has the unfortunate side-effect of breaking the DRM menuconfig to
> > not include the existing DRM options.
>
> These quirks can also be used by fbdev drivers, so the Kconfig option
> intentionally does not have a depends on DRM.
>
> After reading how menuconfig works in Documentation/kbuild/kconfig-language.txt
> I can see how I've broken things, sorry.
>
> But your fix is not correct, the fbdev code does a
> select DRM_PANEL_ORIENTATION_QUIRKS without depending on
> DRM so this will cause circular dependency issues.
>
> The proper fix would be to move the entry entirely to the
> end putting it together with DRM_LIB_RANDOM which also does
> not depend on DRM.
>
> Shall I submit a patch with the proper fix, or will you?
Go for it.
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
