Hello!
On 1/13/2018 12:51 AM, Laurent Pinchart wrote:
On Friday, 12 January 2018 22:12:04 EET Sergei Shtylyov wrote:
According to the latest revisions of the R-Car gen3 manual, the LVDS mode
must be set before the LVDS I/O pins are enabled, not after -- fix the
gen3 LVDS startup sequence accordingly...
While at it, also fix the comment preceding the first LVDCR0 write in
the R-Car gen2 startup code that still talks about hardcoding the LVDS
mode 0...
How about fixing that in patch 2/2 that touches the Gen2 initialization
sequence ? I think I'd even go as far as squashing both patches, I don't think
there's a need to split them.
No. Fixing both issues with 1 patch was intentional because they both were
introduced by the same commit (see Fixes:).
Fixes: e947eccbeba4 ("drm: rcar-du: Add support for LVDS mode selection")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>
Is this really needed ? Does it fix a problem you've experienced, or is it
theoretical only ?
No, just another check against the manual - there were some patches in the
history of this file that did the same thing (sync to the manual). See e.g.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=85e8f8d175caa6a39f4c4e11dd4d0ab038f43324
The mode shouldn't matter before the LVDS internal logic is
turned on. Unless there's a real issue I'm not sure we should make the code
more complex.
Up to you, of course...
[...]
MBR,Sergei
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
