Hi Geert, On Friday, 12 January 2018 11:45:56 EET Geert Uytterhoeven wrote: > On Fri, Jan 12, 2018 at 1:58 AM, Laurent Pinchart wrote: > > The Renesas R-Car Gen2 and Gen3 SoCs have internal LVDS encoders. Add > > corresponding device tree bindings. > > > > Signed-off-by: Laurent Pinchart > > <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > @@ -0,0 +1,54 @@ > > +Renesas R-Car LVDS Encoder > > +========================== > > + > > +These DT bindings describe the LVDS encoder embedded in the Renesas R-Car > > Gen2 +and Gen3 SoCs. > > + > > +Required properties: > > + > > +- compatible : Shall contain one of > > + - "renesas,lvds-r8a7743" for R8A7790 (R-Car RZ/G1M) compatible LVDS > > encoders > > + - "renesas,lvds-r8a7790" for R8A7790 (R-Car H2) compatible LVDS > > encoders > > + - "renesas,lvds-r8a7791" for R8A7791 (R-Car M2-W) compatible LVDS > > encoders > > + - "renesas,lvds-r8a7793" for R8A7791 (R-Car M2-N) compatible LVDS > > encoders > > + - "renesas,lvds-r8a7795" for R8A7795 (R-Car H3) compatible LVDS > > encoders > > + - "renesas,lvds-r8a7796" for R8A7796 (R-Car M3-W) compatible LVDS > > encoders > > + > > +- reg: Base address and length for the memory-mapped registers > > +- clocks: A phandle + clock-specifier pair for the functional clock > > Please document the "resets" property, too, and add it to the example. > According to the rcar-3.6.0 BSP, reset support is needed desperately. Good point. I'll make it mandatory in the new bindings but treat it as optional in the driver as the live DT patching doesn't create the reset properties. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
