Re: [PATCH v2] drm/vc4: Expose performance counters to userspace

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 11 Jan 2018 16:35:08 -0800
Eric Anholt <eric@xxxxxxxxxx> wrote:

> Could we add some docs for get_values?  Like:

Sure.

> 
> /*
>  * Returns the values of the performance counters tracked by this
>  * perfmon (as an array of ncounters u64 values).
>  *
>  * No implicit synchronization is performed, so the user has to
>  * guarantee that any jobs using this perfmon have already been
>  * completed  (probably by blocking on the seqno returned by the
>  * last exec that used the perfmon).
>  */
> 
> With that,
> 
> Reviewed-by: Eric Anholt <eric@xxxxxxxxxx>
> 
> > +struct drm_vc4_perfmon_get_values {
> > +	__u32 id;
> > +	__u64 values_ptr;
> > +};  

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux