Re: [PATCH 2/2] drm/ttm: only free pages rather than update global memory count together

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Both patches

Tested-by: Andrey Grodzovsky <andrey.grodzovsky@xxxxxxx>
Acked-by: Andrey Grodzovsky <andrey.grodzovsky@xxxxxxx>


Andrey


On 01/12/2018 01:14 AM, Roger He wrote:
if ttm_get_pages or ttm_mem_global_alloc_page fail, should not update
global memory count.

Signed-off-by: Roger He <Hongbo.He@xxxxxxx>
---
  drivers/gpu/drm/ttm/ttm_page_alloc.c | 6 ++++--
  1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/ttm/ttm_page_alloc.c b/drivers/gpu/drm/ttm/ttm_page_alloc.c
index 0eab24e..aebabf1 100644
--- a/drivers/gpu/drm/ttm/ttm_page_alloc.c
+++ b/drivers/gpu/drm/ttm/ttm_page_alloc.c
@@ -1075,7 +1075,8 @@ int ttm_pool_populate(struct ttm_tt *ttm, struct ttm_operation_ctx *ctx)
  	ret = ttm_get_pages(ttm->pages, ttm->num_pages, ttm->page_flags,
  			    ttm->caching_state);
  	if (unlikely(ret != 0)) {
-		ttm_pool_unpopulate(ttm);
+		ttm_put_pages(ttm->pages, ttm->num_pages, ttm->page_flags,
+			ttm->caching_state);
  		return ret;
  	}
@@ -1083,7 +1084,8 @@ int ttm_pool_populate(struct ttm_tt *ttm, struct ttm_operation_ctx *ctx)
  		ret = ttm_mem_global_alloc_page(mem_glob, ttm->pages[i],
  						PAGE_SIZE, ctx);
  		if (unlikely(ret != 0)) {
-			ttm_pool_unpopulate(ttm);
+			ttm_put_pages(ttm->pages, ttm->num_pages,
+				ttm->page_flags, ttm->caching_state);
  			return -ENOMEM;
  		}
  	}

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux