Comment # 10
on bug 103107
from Marta Löfstedt
I believe this issue started when the I915_CONTEXT_PARAM_PRIORITY was added. commit ac14fbd460d0ec16e7750e40dcd8199b0ff83d0a Author: Chris Wilson <chris@chris-wilson.co.uk> Date: Tue Oct 3 21:34:53 2017 +0100 drm/i915/scheduler: Support user-defined priorities so instead of hitting default case with -EINVAL return, in i915_gem_context_getparam_ioctl, I915_CONTEXT_PARAM_BANNABLE + 1 gives us I915_CONTEXT_PARAM_PRIORITY. So, we could just change I915_CONTEXT_PARAM_BANNABLE + 1 to I915_CONTEXT_PARAM_PRIORITY + 1, but there is a comment in the testcase: /* NOTE: This testcase intentionally tests for the next free parameter * to catch ABI extensions. Don't "fix" this testcase without adding all * the tests for the new param first. */ As strict interpretation of this gives that subtest for the missing I915_CONTEXT_PARAM_GTT_SIZE, I915_CONTEXT_PARAM_NO_ERROR_CAPTURE, I915_CONTEXT_PARAM_BANNABLE and I915_CONTEXT_PARAM_PRIORITY, needs to be added before changing this test. I.e. this testcase fails because there are niot testcases for all context params.
You are receiving this mail because:
- You are the assignee for the bug.
_______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
