Hi Noralf, Thank you for the patch. On Thursday, 4 January 2018 00:21:05 EET Noralf Trønnes wrote: > Export the following functions so in-kernel users can allocate > dumb buffers: > - drm_file_alloc > - drm_file_free > - drm_prime_handle_to_fd_ioctl > - drm_mode_addfb2 > - drm_mode_create_dumb_ioctl > - drm_dropmaster_ioctl > > Signed-off-by: Noralf Trønnes <noralf@xxxxxxxxxxx> I agree with Daniel's comments. Additionally please see below for one small comment. > --- > drivers/gpu/drm/drm_auth.c | 1 + > drivers/gpu/drm/drm_crtc_internal.h | 4 ---- > drivers/gpu/drm/drm_dumb_buffers.c | 1 + > drivers/gpu/drm/drm_file.c | 2 ++ > drivers/gpu/drm/drm_framebuffer.c | 1 + > drivers/gpu/drm/drm_internal.h | 6 ------ > drivers/gpu/drm/drm_ioctl.c | 1 + > drivers/gpu/drm/drm_prime.c | 1 + > include/drm/drm_auth.h | 3 +++ > include/drm/drm_dumb_buffers.h | 10 ++++++++++ > include/drm/drm_file.h | 2 ++ > include/drm/drm_framebuffer.h | 3 +++ > include/drm/drm_prime.h | 2 ++ > 13 files changed, 27 insertions(+), 10 deletions(-) > create mode 100644 include/drm/drm_dumb_buffers.h [snip] > diff --git a/include/drm/drm_dumb_buffers.h b/include/drm/drm_dumb_buffers.h > new file mode 100644 > index 000000000000..c1138c1c06ab > --- /dev/null > +++ b/include/drm/drm_dumb_buffers.h > @@ -0,0 +1,10 @@ You should add an SPDX header to specify the file license. > +#ifndef _DRM_DUMB_BUFFERS_H_ > +#define _DRM_DUMB_BUFFERS_H_ > + > +struct drm_device; > +struct drm_file; > + > +int drm_mode_create_dumb_ioctl(struct drm_device *dev, > + void *data, struct drm_file *file_priv); > + > +#endif -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
