Re: [PATCH 5/5] drm/tinydrm: Embed the mode in tinydrm_connector

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/06/2018 06:49 AM, Noralf Trønnes wrote:

Den 05.01.2018 20.14, skrev David Lechner:
On 01/05/2018 10:56 AM, Noralf Trønnes wrote:
Embed the mode in tinydrm_connector instead of doing an devm_ allocation.
Remove unnecessary use of ret variable at the end of
tinydrm_display_pipe_init().

Signed-off-by: Noralf Trønnes <noralf@xxxxxxxxxxx>
---
  drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 34 +++++++++++------------------
  1 file changed, 13 insertions(+), 21 deletions(-)

diff --git a/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c b/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c
index f41fc506ff87..dadd26d53216 100644
--- a/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c
+++ b/drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c
@@ -15,7 +15,7 @@
    struct tinydrm_connector {
      struct drm_connector base;
-    const struct drm_display_mode *mode;
+    struct drm_display_mode mode;
  };
    static inline struct tinydrm_connector *
@@ -29,7 +29,7 @@ static int tinydrm_connector_get_modes(struct drm_connector *connector)
      struct tinydrm_connector *tconn = to_tinydrm_connector(connector);
      struct drm_display_mode *mode;
  -    mode = drm_mode_duplicate(connector->dev, tconn->mode);
+    mode = drm_mode_duplicate(connector->dev, &tconn->mode);
      if (!mode) {
          DRM_ERROR("Failed to duplicate mode\n");
          return 0;
@@ -92,7 +92,7 @@ tinydrm_connector_create(struct drm_device *drm,
      if (!tconn)
          return ERR_PTR(-ENOMEM);
  -    tconn->mode = mode;
+    tconn->mode = *mode;

I see there is a special drm_mode_copy() function, so I am wondering if this
is safe.


It is safe, the underlying drm_mode_object isn't initialized/registered.
So to me an assignment like this makes it clear that it is so, but Laurent
also asked about this, so maybe I'm the odd one here.
I'll switch to drm_mode_copy().


I think a comment to this effect would be enough.
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux