Re: [PATCH 1/5] drm/tinydrm/mi0283qt: Use common include order

[David Lechner <david@xxxxxxxxxxxxxx>]

On 01/05/2018 10:55 AM, Noralf Trønnes wrote:
> Include linux headers before drm headers as it's commonly done.
>
> Signed-off-by: Noralf Trønnes <noralf@xxxxxxxxxxx>
> ---
>   drivers/gpu/drm/tinydrm/mi0283qt.c | 11 ++++++-----
>   1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/tinydrm/mi0283qt.c b/drivers/gpu/drm/tinydrm/mi0283qt.c
> index 674d407640be..45f02b6052b1 100644
> --- a/drivers/gpu/drm/tinydrm/mi0283qt.c
> +++ b/drivers/gpu/drm/tinydrm/mi0283qt.c
> @@ -9,17 +9,18 @@
>    * (at your option) any later version.
>    */
>   
> -#include <drm/drm_fb_helper.h>
> -#include <drm/drm_modeset_helper.h>
> -#include <drm/tinydrm/ili9341.h>
> -#include <drm/tinydrm/mipi-dbi.h>
> -#include <drm/tinydrm/tinydrm-helpers.h>
>   #include <linux/delay.h>
>   #include <linux/gpio/consumer.h>
>   #include <linux/module.h>
>   #include <linux/property.h>
>   #include <linux/regulator/consumer.h>
>   #include <linux/spi/spi.h>
> +
> +#include <drm/drm_fb_helper.h>
> +#include <drm/drm_modeset_helper.h>
> +#include <drm/tinydrm/ili9341.h>
> +#include <drm/tinydrm/mipi-dbi.h>
> +#include <drm/tinydrm/tinydrm-helpers.h>
>   #include <video/mipi_display.h>
>   
>   static int mi0283qt_init(struct mipi_dbi *mipi)

Reviewed-by: David Lechner <david@xxxxxxxxxxxxxx>
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel