On 01/01/18 13:55, Jyri Sarha wrote: > This the v2 rouns of a this RFC patch: > https://patchwork.kernel.org/patch/10066245/ > > The first patch is a simple fix that should be applied in any case. > > I did not split the mgr_has_framedone() callback as a separate patch. It > quite literally replaces the mgr_get_framedone_irq() and makes no > sense without the "drm/omap: Make omapdss API more generic"-patch. > > The patches have been rebased on top of the latest drm-next > (350877626faba5d60cbb8cef2bdeb524212c780b). > > Best regards, > Jyri > > Jyri Sarha (3): > drm/omap: Fail probe if irq registration fails > drm/omap: Add get_ovl_name() and get_mgr_name() to dispc_ops > drm/omap: Make omapdss API more generic I think the first two patches look fine. The third patch is, of course, the interesting one. I did have some comments for that. To be honest, I'm not sure what kind of irqhandling we'll end up with when we get the omapdss & omapdrm merge completed and add support for DSS6. But I still think this cleans up things. So even if in the end we'd end up not using common irq code, the way there will be easier with these changes. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
