Am Freitag, den 15.12.2017, 10:33 +0100 schrieb Lucas Stach:
> Am Freitag, den 15.12.2017, 08:43 +0100 schrieb Christian Gmeiner:
> > Add etna_cmd_stream_perf(..) to submit perform requests.
> > Userspace can submit pmrs via submit ioctl to sample perfmon
> > signals.
> >
> > v3:
> > - mark perfmon bos as RW
> >
> > Signed-off-by: Christian Gmeiner <christian.gmeiner@xxxxxxxxx>
> > ---
>
> [...]
>
> > #endif /* ETNAVIV_DRMIF_H_ */
> > diff --git a/etnaviv/etnaviv_priv.h b/etnaviv/etnaviv_priv.h
> > index 7b289b61..e45d364c 100644
> > --- a/etnaviv/etnaviv_priv.h
> > +++ b/etnaviv/etnaviv_priv.h
> > @@ -140,6 +140,10 @@ struct etna_cmd_stream_priv {
> > /* reloc's table: */
> > struct drm_etnaviv_gem_submit_reloc *relocs;
> > uint32_t nr_relocs, max_relocs;
> > +
> > + /* perf's table: */
> > + struct drm_etnaviv_gem_submit_pmr *pmrs;
> > + uint32_t nr_pmrs, max_pmrs;
>
> On v2 I commented that I don't see max_pmrs used anywhere. If it's
> unused please remove before pushing the patch.
... And I just saw your reply to my v2 review explaining this stuff. So
please disregard this comment.
> Since this is a nitpick, you have my
>
> Reviewed-by: Lucas Stach <l.stach@xxxxxxxxxxxxxx>
>
> Regards,
> Lucas
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
