On Wed, Dec 13, 2017 at 02:35:16PM +0100, Daniel Vetter wrote: > On Wed, Dec 13, 2017 at 01:05:49PM +0000, Chris Wilson wrote: > > Quoting Daniel Vetter (2017-12-13 12:49:36) > > > diff --git a/drivers/gpu/drm/drm_mode_config.c b/drivers/gpu/drm/drm_mode_config.c > > > index 6ffe952142e6..7681269abe41 100644 > > > --- a/drivers/gpu/drm/drm_mode_config.c > > > +++ b/drivers/gpu/drm/drm_mode_config.c > > > @@ -382,6 +382,8 @@ void drm_mode_config_init(struct drm_device *dev) > > > ida_init(&dev->mode_config.connector_ida); > > > spin_lock_init(&dev->mode_config.connector_list_lock); > > > > > > + INIT_WORK(&dev->mode_config.connector_free_work, drm_connector_free_work_fn); > > > > A init_llist_head(&dev->mode_config.connector_free_list) wouldn't go > > amiss here. So perhaps push the connectors init into its own exported > > function from drm_connector.c as opposed to exposing the free_fn. > > Imo it doesn't matter much how we go about drm.ko internals. But I'll > stick the init_llist_head in there when applying, somehow I dind't find it > (why is every kernel data type slightly different in this). > > > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> And applied with init_llist_head added. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
