Re: [PATCH] drm/ttm: swap consecutive allocated pooled pages v4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Christian,

I love your patch! Yet something to improve:

[auto build test ERROR on drm/drm-next]
[also build test ERROR on v4.15-rc2 next-20171206]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Christian-K-nig/drm-ttm-swap-consecutive-allocated-pooled-pages-v4/20171206-191635
base:   git://people.freedesktop.org/~airlied/linux.git drm-next
config: i386-randconfig-x014-201749 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers/gpu//drm/ttm/ttm_page_alloc.c: In function 'ttm_get_pages':
>> drivers/gpu//drm/ttm/ttm_page_alloc.c:924:2: error: 'first' undeclared (first use in this function)
     first = count;
     ^~~~~
   drivers/gpu//drm/ttm/ttm_page_alloc.c:924:2: note: each undeclared identifier is reported only once for each function it appears in

vim +/first +924 drivers/gpu//drm/ttm/ttm_page_alloc.c

   919	
   920		INIT_LIST_HEAD(&plist);
   921		r = ttm_page_pool_get_pages(pool, &plist, flags, cstate,
   922					    npages - count, 0);
   923	
 > 924		first = count;
   925		list_for_each_entry(p, &plist, lru) {
   926			struct page *tmp = p;
   927	
   928			/* Swap the pages if we detect consecutive order */
   929			if (count > first && pages[count - 1] == tmp - 1)
   930				swap(tmp, pages[count - 1]);
   931			pages[count++] = tmp;
   932		}
   933	
   934		if (r) {
   935			/* If there is any pages in the list put them back to
   936			 * the pool.
   937			 */
   938			pr_debug("Failed to allocate extra pages for large request\n");
   939			ttm_put_pages(pages, count, flags, cstate);
   940			return r;
   941		}
   942	
   943		return 0;
   944	}
   945	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux