On Wed, Nov 29, 2017 at 12:33:24PM +0100, msrb@xxxxxxxx wrote:
> From: Michal Srb <msrb@xxxxxxxx>
>
> The io_mem_pfn field was added in ea642c3216cb2a60d1c0e760ae47ee85c9c16447 and
> is used unconditionally. Most drivers were updated to set it to the default
> implementation ttm_bo_default_io_mem_pfn, but hibmc was not.
>
> This fixes crash in ttm_bo_vm_fault when hibmc driver is used.
Instead of just doing the same cargo cult in this driver, lets just call the
default function when io_mem_pfn is NULL. Looks like 9 other drivers are
affected as well.
Sean
>
> Signed-off-by: Michal Srb <msrb@xxxxxxxx>
> ---
> drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c
> index 3518167a7dc4..0b165ce4ee00 100644
> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c
> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c
> @@ -243,6 +243,7 @@ struct ttm_bo_driver hibmc_bo_driver = {
> .verify_access = hibmc_bo_verify_access,
> .io_mem_reserve = &hibmc_ttm_io_mem_reserve,
> .io_mem_free = NULL,
> + .io_mem_pfn = ttm_bo_default_io_mem_pfn,
> };
>
> int hibmc_mm_init(struct hibmc_drm_private *hibmc)
> --
> 2.13.6
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
