Re: [PATCH v3] drm: bridge: synopsys/dw-hdmi: Enable cec clock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

>> On 11/20/2017 06:00 PM, Hans Verkuil wrote:
>>> I didn't see this merged for 4.15, is it too late to include this?
>>> All other changes needed to get CEC to work on rk3288 and rk3399 are all merged.
>>
>> Sorry for the late reply. I was out last week.
>>
>> Dave recently sent the second pull request for 4.15, so I think it would be hard to get it
>> in the merge window now. We could target it for the 4.15-rcs since it is preventing the
>> feature from working. Is it possible to rephrase the commit message a bit so that it's clear
>> that we need it for CEC to work?
>
> While it is not my patch I would propose something like this:
>
> "Support the "cec" optional clock. The documentation already mentions "cec"
> optional clock and it is used by several boards, but currently the driver
> doesn't enable it, thus preventing cec from working on those boards.
>
> And even worse: a /dev/cecX device will appear for those boards, but it
> won't be functioning without configuring this clock."
>
> I hadn't realized that last sentence until I started thinking about it,
> but this patch is really needed.
This change looks good to me.

Archit, I can send this as a new version of the patch tomorrow if you need it.

Regards,
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux