Hi Colin, On 17/11/17 20:49, Colin King wrote: > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The two comparisons of the unsigned int ret for -ve error returns is > always false because ret is unsigned. Fix this by making ret a signed > int. > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c > index d86873f2abe6..e626eddf24d5 100644 > --- a/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c > +++ b/drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c > @@ -352,7 +352,7 @@ int hdmi4_cec_init(struct platform_device *pdev, struct hdmi_core_data *core, > { > const u32 caps = CEC_CAP_TRANSMIT | CEC_CAP_LOG_ADDRS | > CEC_CAP_PASSTHROUGH | CEC_CAP_RC; > - unsigned int ret; > + int ret; > > core->adap = cec_allocate_adapter(&hdmi_cec_adap_ops, core, > "omap4", caps, CEC_MAX_LOG_ADDRS); > Thanks. There was an earlier patch from Dan Carpenter for this, which I have applied. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel