2017-11-17 11:36 GMT+01:00 Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>: > platform_get_irq_byname() can fail here and we must check its return > value. > Applied on drm-misc-next. Thanks, Benjamin > Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx> > --- > drivers/gpu/drm/sti/sti_hdmi.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c > index 30f02d2..adabd41 100644 > --- a/drivers/gpu/drm/sti/sti_hdmi.c > +++ b/drivers/gpu/drm/sti/sti_hdmi.c > @@ -1414,6 +1414,11 @@ static int sti_hdmi_probe(struct platform_device *pdev) > init_waitqueue_head(&hdmi->wait_event); > > hdmi->irq = platform_get_irq_byname(pdev, "irq"); > + if (hdmi->irq < 0) { > + DRM_ERROR("Cannot get HDMI irq\n"); > + ret = hdmi->irq; > + goto release_adapter; > + } > > ret = devm_request_threaded_irq(dev, hdmi->irq, hdmi_irq, > hdmi_irq_thread, IRQF_ONESHOT, dev_name(dev), hdmi); > -- > 2.7.4 > _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel