On Fri, Oct 28, 2011 at 6:56 PM, Keith Packard <keithp@xxxxxxxxxx> wrote: > Kernels with no iommu support cannot ever need the Ironlake > work-around, so never enable it in that case. > > Might be better to completely remove the work-around from the kernel > in this case? > While I'm not offended by this patch, I am offended by the extern int intel_iommu_gfx_mapped; introduced in the previous patches, I dislike having extern declarations in a C file, a header file is the place for that sort of thing. Also have a look around some other places that do CONFIG_ stuff, I think there may be examples of both in which case this approach is fine, but I do remember there being a fair few, #ifdef CONFIG_BLAH function #else #define function do while(0) #endif Dave. _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
