On Tue, Nov 14, 2017 at 1:32 PM, Ville Syrjala
<ville.syrjala@xxxxxxxxxxxxxxx> wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> Reject any mode with DRM_MODE_FLAG_PIXMUX. We have no code that even
> checks for this flag hence it can't possibly do any good.
>
> Looks like this flag had something to do the the controller<->ramdac
> interface with some ancient S3 graphics adapters. Why someone though
> it would be a good idea to expose it directly to users I don't know.
> And later on it got copied into the randr protocol and kms uapi.
>
> Cc: Jose Abreu <Jose.Abreu@xxxxxxxxxxxx>
> Cc: Adam Jackson <ajax@xxxxxxxxxx>
> Cc: Keith Packard <keithp@xxxxxxxxxx>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Reviewed-by: Alex Deucher <alexander.deucher@xxxxxxx>
> ---
> include/drm/drm_modes.h | 2 +-
> include/uapi/drm/drm_mode.h | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
> index 9f3421c8efcd..bce573375dd8 100644
> --- a/include/drm/drm_modes.h
> +++ b/include/drm/drm_modes.h
> @@ -300,7 +300,7 @@ struct drm_display_mode {
> * - DRM_MODE_FLAG_NCSYNC: composite sync is active low.
> * - DRM_MODE_FLAG_HSKEW: hskew provided (not used?).
> * - DRM_MODE_FLAG_BCAST: not used?
> - * - DRM_MODE_FLAG_PIXMUX: not used?
> + * - DRM_MODE_FLAG_PIXMUX: <deprecated>
> * - DRM_MODE_FLAG_DBLCLK: double-clocked mode.
> * - DRM_MODE_FLAG_CLKDIV2: half-clocked mode.
> *
> diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
> index 004db470b477..8d872e17223e 100644
> --- a/include/uapi/drm/drm_mode.h
> +++ b/include/uapi/drm/drm_mode.h
> @@ -75,7 +75,7 @@ extern "C" {
> #define DRM_MODE_FLAG_NCSYNC (1<<8)
> #define DRM_MODE_FLAG_HSKEW (1<<9) /* hskew provided */
> #define DRM_MODE_FLAG_BCAST (1<<10)
> -#define DRM_MODE_FLAG_PIXMUX (1<<11)
> +#define DRM_MODE_FLAG_PIXMUX (1<<11) /* deprecated */
> #define DRM_MODE_FLAG_DBLCLK (1<<12)
> #define DRM_MODE_FLAG_CLKDIV2 (1<<13)
> /*
> @@ -118,7 +118,6 @@ extern "C" {
> DRM_MODE_FLAG_NCSYNC | \
> DRM_MODE_FLAG_HSKEW | \
> DRM_MODE_FLAG_BCAST | \
> - DRM_MODE_FLAG_PIXMUX | \
> DRM_MODE_FLAG_DBLCLK | \
> DRM_MODE_FLAG_CLKDIV2 | \
> DRM_MODE_FLAG_3D_MASK)
> --
> 2.13.6
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
