Quoting Chris Wilson (2017-11-14 14:39:29)
> Quoting Christian König (2017-11-14 14:24:35)
> > The amdgpu issue to also need signaled fences in the reservation objects
> > should be fixed by now.
> >
> > Optimize the list by keeping only the not signaled yet fences around.
> >
> > v2: temporary put the signaled fences at the end of the new container
> > v3: put the old fence at the end of the new container as well.
> >
> > Signed-off-by: Christian König <christian.koenig@xxxxxxx>
> > ---
> > - if (!old_fence) {
> > - RCU_INIT_POINTER(fobj->shared[fobj->shared_count], fence);
> > - fobj->shared_count++;
> > + if (check->context == fence->context ||
> > + dma_fence_is_signaled(check))
> > + RCU_INIT_POINTER(fobj->shared[--k], check);
> > + else
> > + RCU_INIT_POINTER(fobj->shared[j++], check);
> > }
> > + fobj->shared_count = j;
> > + RCU_INIT_POINTER(fobj->shared[fobj->shared_count], fence);
> > + fobj->shared_count++;
>
> I would keep the INIT_PTR(fobj->shared[j++], fence);
> fobj->shared_count = j;
>
> Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>
> I've been running an equivalent patch through our CI with nothing to
> report.
Make as well make that formal,
Tested-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
