On Mon, Nov 13, 2017 at 06:30:47PM +0000, Jose Abreu wrote: > > > On 13-11-2017 17:04, Ville Syrjala wrote: > > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > > > If the user mode would specify an aspect ratio other than 4:3 or 16:9 > > we now silently ignore it. Maybe a better apporoach is to return an > > error? Let's try that. > > > > Also we must be careful that we don't try to send illegal picture > > aspect in the infoframe as it's only capable of signalling none, > > 4:3, and 16:9. Currently we're sending these bogus infoframes > > whenever the cea mode specifies some other aspect ratio. > > > > > > Yes, this is a bug. Following my input from the previous patch I > think you should also check for HDMI_PICTURE_ASPECT_RESERVED or RESERVED > 16_9 > user a helper to check that. I'm also wondering if this should go > to stable since the vics with aspect ratio > 16:9 were > introduced. We are indeed corrupting the AVI infoframe. Possibly. Just need to be careful we don't end up making a bigger mess in stable. I has some concerns about the ordering of these patches, but I guess that was between this patch and the next patch that starts to reject the illegal aspect ratios in the infoframe code. So just backporting this one alone (or both patches) should be fine. -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
