Can't find these anywhere yet, errors still there. https://patchwork.freedesktop.org/series/31220/ Regards //Ernst 2017-09-30 10:25 GMT+02:00 Christian König <christian.koenig@xxxxxxx>: > Am 30.09.2017 um 10:13 schrieb Dan Carpenter: >> >> We shifted some code around in commit 9cca0b8e5df0 ("drm/amdgpu: move >> amdgpu_cs_sysvm_access_required into find_mapping") and now my static >> checker complains that "r" might not be initialized at the end of the >> function. I've reviewed the code, and that seems possible, but it's >> also possible I may have missed something. >> >> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > > Good catches, Reviewed-by: Christian König <christian.koenig@xxxxxxx> for > both patches. > > >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c >> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c >> index b46280c1279f..2918de2f39ec 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c >> @@ -648,7 +648,7 @@ int amdgpu_vce_ring_parse_cs(struct amdgpu_cs_parser >> *p, uint32_t ib_idx) >> uint32_t allocated = 0; >> uint32_t tmp, handle = 0; >> uint32_t *size = &tmp; >> - int i, r, idx = 0; >> + int i, r = 0, idx = 0; >> p->job->vm = NULL; >> ib->gpu_addr = amdgpu_sa_bo_gpu_addr(ib->sa_bo); > > > > _______________________________________________ > amd-gfx mailing list > amd-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel