Re: [PATCH 09/23] drm/sis: use drm_mm instead of drm_sman

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 29, 2011 at 12:47:18AM +0200, Tormod Volden wrote:
> On Thu, Oct 27, 2011 at 1:07 PM, Daniel Vetter <daniel.vetter@xxxxxxxx> wrote:
> ...
> > @@ -139,13 +99,35 @@ static int sis_drm_alloc(struct drm_device *dev, struct drm_file *file,
> ...
> > +#if defined(CONFIG_FB_SIS) || defined(CONFIG_FB_SIS_MODULE)
> > +               item->req.size = mem->size;
> > +               sis_malloc(&item->req);
> > +               if (item->req.size == 0)
> > +                       retval = -ENOMEN;
> 
> ENOMEN is omen, I guess this was not compile tested with either CONFIG?

Oh gosh, this is embarassing ;-) I've indeed fumbled this and forgotten to
check that config option. Smashed your patch on top of mine. btw, do you
have some actual hw to test this on, or have you just checked out of
curiosity?

Thanks, Daniel
-- 
Daniel Vetter
Mail: daniel@xxxxxxxx
Mobile: +41 (0)79 365 57 48
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
http://lists.freedesktop.org/mailman/listinfo/dri-devel



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux