On Wed, Nov 01, 2017 at 04:20:56PM +0200, Jani Nikula wrote: > We were recently bitten by drm_edid_to_eld() clearing the connector > type, and us failing to set it back for DP. Here's a few ELD related > patches to try to unify ELD handling and make it a bit simpler for > drivers to get it right. > > Apologies for the massive Cc list; it's the maintainers of all drivers > that call drm_edid_to_eld(). > > I'm open to splitting up patch 6 to driver specific patches as needed, > but I'd think it would be just fine to merge via drm-misc as-is too. Entire series lgtm so Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > BR, > Jani. > > Cc: Alex Deucher <alexander.deucher@xxxxxxx> > Cc: Christian König <christian.koenig@xxxxxxx> > Cc: Archit Taneja <architt@xxxxxxxxxxxxxx> > Cc: Andrzej Hajda <a.hajda@xxxxxxxxxxx> > Cc: Russell King <linux@xxxxxxxxxxxxxxx> > Cc: CK Hu <ck.hu@xxxxxxxxxxxx> > Cc: Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> > Cc: Ben Skeggs <bskeggs@xxxxxxxxxx> > Cc: Mark Yao <mark.yao@xxxxxxxxxxxxxx> > Cc: Benjamin Gaignard <benjamin.gaignard@xxxxxxxxxx> > Cc: Vincent Abriou <vincent.abriou@xxxxxx> > Cc: Thierry Reding <thierry.reding@xxxxxxxxx> > Cc: Eric Anholt <eric@xxxxxxxxxx> > > > Jani Nikula (7): > drm/edid: use macros for ELD offsets and values > drm/edid: set ELD connector type in drm_edid_to_eld() > drm/i915: remove redundant ELD connector type update > drm/edid: abstract connector ELD clearing > drm/edid: build ELD in drm_add_edid_modes() > drm/drivers: drop redundant drm_edid_to_eld() calls > drm/edid: make drm_edid_to_eld() static > > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 1 - > drivers/gpu/drm/bridge/analogix-anx78xx.c | 2 - > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 2 - > drivers/gpu/drm/drm_edid.c | 70 +++++++++++++++----------- > drivers/gpu/drm/i2c/tda998x_drv.c | 1 - > drivers/gpu/drm/i915/intel_dp.c | 1 - > drivers/gpu/drm/i915/intel_modes.c | 18 ------- > drivers/gpu/drm/mediatek/mtk_hdmi.c | 1 - > drivers/gpu/drm/nouveau/nv50_display.c | 5 +- > drivers/gpu/drm/radeon/radeon_connectors.c | 1 - > drivers/gpu/drm/radeon/radeon_dp_mst.c | 1 - > drivers/gpu/drm/rockchip/cdn-dp-core.c | 4 +- > drivers/gpu/drm/sti/sti_hdmi.c | 1 - > drivers/gpu/drm/tegra/output.c | 1 - > drivers/gpu/drm/vc4/vc4_hdmi.c | 1 - > include/drm/drm_edid.h | 1 - > include/drm/drm_modeset_helper_vtables.h | 3 -- > 17 files changed, 44 insertions(+), 70 deletions(-) > > -- > 2.11.0 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
