Re: [RESEND PATCH] drm/hisilicon: Ensure LDI regs are properly configured.

liuxinliang <z.liuxinliang@xxxxxxxxxxxxx> · Wed, 25 Oct 2017 09:00:38 +0800



    Hi Peter,

    
    On 2017/10/24 1:34, Peter Griffin
      wrote:

    
      Hi Xinliang,
        

          On 28 August 2017 at 10:27, Xinliang
            Liu <xinliang.liu@xxxxxxxxxx>
            wrote:

            Hi
              Daniel,

              
                  On 28 August 2017 at 16:51, Daniel Vetter <daniel@xxxxxxxx>
                  wrote:

                  > On Mon, Aug 28, 2017 at 04:44:30PM +0800,
                  Xinliang Liu wrote:

                  >> Hi,

                  >>

                  >> On 15 August 2017 at 22:14, Peter Griffin
                  <peter.griffin@xxxxxxxxxx>
                  wrote:

                  >>

                  >> > This patch fixes the following soft
                  lockup:

                  >> >   BUG: soft lockup - CPU#0 stuck for
                  23s! [weston:307]

                  >> >

                  >> > On weston idle-timeout the IP is powered
                  down and reset

                  >> > asserted. On weston resume we get a
                  massive vblank

                  >> > IRQ storm due to the LDI registers
                  having lost some state.

                  >> >

                  >> > This state loss is caused by
                  ade_crtc_atomic_begin() not

                  >> > calling ade_ldi_set_mode(). With this
                  patch applied

                  >> > resuming from Weston idle-timeout works
                  well.

                  >> >

                  >> > Signed-off-by: Peter Griffin <peter.griffin@xxxxxxxxxx>

                  >> > Tested-by: John Stultz <john.stultz@xxxxxxxxxx>

                  >> >

                  >>

                  >> Thanks Peter,

                  >> This patch looks good to me.

                  >> Reviewed-by: Xinliang Liu <xinliang.liu@xxxxxxxxxx>

                  >>

                  >> @Sean, could you please help to apply to
                  drm-misc if others has no more

                  >> comments, thanks.

                  >

                  > hisilicon isn't maintained in drm-misc, and
                  you're the maintainer. This is

                  > not how it works. So either

                  > a) pick up the patch and send out a pull request
                  to Dave Airlie

                  > b) move hisilicon over to drm-misc and become a
                  drm-misc maintainer

                  > yourself. This needs a MAINTAINERS update to
                  point the git tree at

                  > drm-misc.

                  >

                  > drm-misc maintainers don't maintain everyone
                  else's driver as a service,

                  > that simply doesn't scale.

                  
              Sorry for my misunderstanding and thanks for pointing out
              that how

              drm-misc works.

              So I will pick up the patch and send a pull request.

            
            Did you send the pull request?
            

            I still can't see this patch in the latest kernel RC.
          
        
    I have sent in last cycle, it seems it didn't catch last cycle.
    Maybe I need to resend again this cycle.

    Will send soon.

    
    Thanks,

    Xinliang

    
            Peter.
          
        
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel