For drivers which could have multiple instances, it is necessary to differentiate between which is which in the logs. Since DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to make this differentiation. We now have DRM_DEV_* variants of the drm print macros, so we can start to convert those drivers back to using drm-formatted specific log messages. This patch is using following Coccinelle script: @@ @@ ( - dev_info + DRM_DEV_INFO | - dev_err + DRM_DEV_ERROR | - dev_dbg + DRM_DEV_DEBUG ) Signed-off-by: Aastha Gupta <aastha.gupta4104@xxxxxxxxx> --- drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c index 797bbc7..583f96f 100644 --- a/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c +++ b/drivers/gpu/drm/panel/panel-samsung-s6e3ha2.c @@ -454,7 +454,7 @@ static int s6e3ha2_set_brightness(struct backlight_device *bl_dev) if (brightness < S6E3HA2_MIN_BRIGHTNESS || brightness > bl_dev->props.max_brightness) { - dev_err(ctx->dev, "Invalid brightness: %u\n", brightness); + DRM_DEV_ERROR(ctx->dev, "Invalid brightness: %u\n", brightness); return -EINVAL; } @@ -702,28 +702,28 @@ static int s6e3ha2_probe(struct mipi_dsi_device *dsi) ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(ctx->supplies), ctx->supplies); if (ret < 0) { - dev_err(dev, "failed to get regulators: %d\n", ret); + DRM_DEV_ERROR(dev, "failed to get regulators: %d\n", ret); return ret; } ctx->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(ctx->reset_gpio)) { - dev_err(dev, "cannot get reset-gpios %ld\n", - PTR_ERR(ctx->reset_gpio)); + DRM_DEV_ERROR(dev, "cannot get reset-gpios %ld\n", + PTR_ERR(ctx->reset_gpio)); return PTR_ERR(ctx->reset_gpio); } ctx->enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_HIGH); if (IS_ERR(ctx->enable_gpio)) { - dev_err(dev, "cannot get enable-gpios %ld\n", - PTR_ERR(ctx->enable_gpio)); + DRM_DEV_ERROR(dev, "cannot get enable-gpios %ld\n", + PTR_ERR(ctx->enable_gpio)); return PTR_ERR(ctx->enable_gpio); } ctx->bl_dev = backlight_device_register("s6e3ha2", dev, ctx, &s6e3ha2_bl_ops, NULL); if (IS_ERR(ctx->bl_dev)) { - dev_err(dev, "failed to register backlight device\n"); + DRM_DEV_ERROR(dev, "failed to register backlight device\n"); return PTR_ERR(ctx->bl_dev); } -- 2.7.4 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel