For drivers which could have multiple instances, it is necessary to differentiate between which is which in the logs. Since DRM_INFO/WARN/ERROR don’t do this, drivers used dev_info/warn/err to make this differentiation. We now have DRM_DEV_* variants of the drm print macros, so we can start to convert those drivers back to using drm-formwatted specific log messages. Signed-off-by: Aastha Gupta <aastha.gupta4104@xxxxxxxxx> --- drivers/gpu/drm/etnaviv/etnaviv_buffer.c | 4 ++-- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 9 +++++---- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_buffer.c b/drivers/gpu/drm/etnaviv/etnaviv_buffer.c index ed9588f..0091a8b 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_buffer.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_buffer.c @@ -125,8 +125,8 @@ static void etnaviv_buffer_dump(struct etnaviv_gpu *gpu, u32 size = buf->size; u32 *ptr = buf->vaddr + off; - dev_info(gpu->dev, "virt %p phys 0x%08x free 0x%08x\n", - ptr, etnaviv_cmdbuf_get_va(buf) + off, size - len * 4 - off); + DRM_DEV_INFO(gpu->dev, "virt %p phys 0x%08x free 0x%08x\n", ptr, + etnaviv_cmdbuf_get_va(buf) + off, size - len * 4 - off); print_hex_dump(KERN_INFO, "cmd ", DUMP_PREFIX_OFFSET, 16, 4, ptr, len * 4, 0); diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c index fc9a6a8..862beac 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c @@ -344,8 +344,8 @@ static void etnaviv_hw_identify(struct etnaviv_gpu *gpu) } } - dev_info(gpu->dev, "model: GC%x, revision: %x\n", - gpu->identity.model, gpu->identity.revision); + DRM_DEV_INFO(gpu->dev, "model: GC%x, revision: %x\n", + gpu->identity.model, gpu->identity.revision); gpu->identity.features = gpu_read(gpu, VIVS_HI_CHIP_FEATURE); @@ -673,7 +673,7 @@ int etnaviv_gpu_init(struct etnaviv_gpu *gpu) /* Exclude VG cores with FE2.0 */ if (gpu->identity.features & chipFeatures_PIPE_VG && gpu->identity.features & chipFeatures_FE20) { - dev_info(gpu->dev, "Ignoring GPU with VG and FE2.0\n"); + DRM_DEV_INFO(gpu->dev, "Ignoring GPU with VG and FE2.0\n"); ret = -ENXIO; goto fail; } @@ -695,7 +695,8 @@ int etnaviv_gpu_init(struct etnaviv_gpu *gpu) else gpu->memory_base = dma_mask - SZ_2G + 1; } else if (PHYS_OFFSET >= SZ_2G) { - dev_info(gpu->dev, "Need to move linear window on MC1.0, disabling TS\n"); + DRM_DEV_INFO(gpu->dev, + "Need to move linear window on MC1.0, disabling TS\n"); gpu->memory_base = PHYS_OFFSET; gpu->identity.features &= ~chipFeatures_FAST_CLEAR; } -- 2.7.4 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel