On Tue, Oct 25, 2011 at 10:20:13PM -0400, Ilija Hadzic wrote: > drm_getmap, drm_getclient and drm_getstats are all > protected with their own mutex (dev->struct_mutex) > no need to hold global mutex; make them DRM_UNLOCKED > > Signed-off-by: Ilija Hadzic <ihadzic@xxxxxxxxxxxxxxxxxxxxxx> Just to check before I dig into reviewing this: Have you check all the other users of these data structure that these functions touch whether they don't accidentally rely on the global lock being taken? Just because there's some locking around doesn't mean it actually protects much ... I ask because I've just recently waded through the non-kms drm cruft again and there's some horrible stuff there. Yours, Daniel -- Daniel Vetter Mail: daniel@xxxxxxxx Mobile: +41 (0)79 365 57 48 _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx http://lists.freedesktop.org/mailman/listinfo/dri-devel
