Hi Sebastian, On Wednesday, 18 October 2017 01:29:56 EEST Sebastian Reichel wrote: > On Fri, Oct 13, 2017 at 05:58:56PM +0300, Laurent Pinchart wrote: > > This patch series merges the omapdrm and omapdss drivers into a single > > driver called omapdrm. The split in two drivers was historical, in order > > to support the FBDEV, V4L2 and DRM/KMS APIs. Now that the driver supports > > DRM/KMS only there's no need to keep two seperate drivers. > > > > The series starts with a few cleanups (01/48 to 03/48) and quickly > > proceeds to merging the omapdss and omapdss-base modules (04/48). It then > > prepares the omapdss code (05/48 to 08/48), perform a few more cleanups > > (09/48 to 11/48) and prepares the omapdrm code (12/48). > > > > Patches 13/48 to 19/48 prepare the connector, encoder and panel drivers. > > All those drivers defer probing when their video source can't be found at > > probe time. This would cause endless probe deferral when merging omapdrm > > and omapdss as the drivers need omapdss to be fully initialized to probe > > successfully, but cause omapdrm to defer probing when they're not > > available. > > > > Patch 20/48 merges the omapdrm and omapdss drivers. > > > > The next patches are added bonuses that start removal of global variables > > from the driver. The code relies heavily on global variables for objects > > that are instance-specific, and should thus be dynamically allocated. > > Most of the patches change internal APIs to pass objects to driver > > functions (21/48 to 28/48, 36/48, 39/48 to 41/38, 43/48 to 45/48) with a > > few miscellaneous cleanups (29/48, 35/48, 37/48, 38/48, 42/48). Patches > > 30/48 to 34/48 and 46/48 then allocate instance objects dynamically to > > replace global variables, and patches 47/48 and 48/48 move global > > variables to existing instance objects. > > > > The series has been tested on a Pandaboard with the DVI and HDMI output. > > Nice cleanup! :) And great review ! :-) Thank you. There will be more coming, probably another cleanup round before I start moving the encoder, connector and panel drivers to drm_bridge and drm_panel. -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel
