Hi：
Thanks for the patch. This problem has been fixed on staging branch with:
a8e18bfc854141621a29600a6c13e5f40c6e9f19
drm/i915/gvt: Refine shadow batch buffer
Thanks,
Zhi.
-----Original Message-----
From: Christos Gkekas [mailto:chris.gekas@xxxxxxxxx]
Sent: Monday, October 16, 2017 1:18 AM
To: Gao, Fred <fred.gao@xxxxxxxxx>; Zhenyu Wang <zhenyuw@xxxxxxxxxxxxxxx>; Wang, Zhi A <zhi.a.wang@xxxxxxxxx>; Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>; Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>; David Airlie <airlied@xxxxxxxx>; intel-gvt-dev@xxxxxxxxxxxxxxxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Cc: Christos Gkekas <chris.gekas@xxxxxxxxx>
Subject: [PATCH] drm/i915/gvt: Fix error handling bug in perform_bb_shadow
Change the type of variable 'bb_size' from uint32_t to int to be able to hold error return values from find_bb_size(). This change seems to have been missed from previous commit 1e3197d6ad73.
Signed-off-by: Christos Gkekas <chris.gekas@xxxxxxxxx>
---
drivers/gpu/drm/i915/gvt/cmd_parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c
index 2c0ccbb..f41cbf6 100644
--- a/drivers/gpu/drm/i915/gvt/cmd_parser.c
+++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c
@@ -1628,7 +1628,7 @@ static int perform_bb_shadow(struct parser_exec_state *s)
struct intel_shadow_bb_entry *entry_obj;
struct intel_vgpu *vgpu = s->vgpu;
unsigned long gma = 0;
- uint32_t bb_size;
+ int bb_size;
void *dst = NULL;
int ret = 0;
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel
