Re: [PATCH 16/48] drm: omapdrm: displays: Remove OF node check in panel drivers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Oct 13, 2017 at 05:59:12PM +0300, Laurent Pinchart wrote:
> No panel is instantiated through platform data anymore, there is no
> need to check for OF node presence.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx>

-- Sebastian

>  drivers/gpu/drm/omapdrm/displays/panel-dpi.c                | 3 ---
>  drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c             | 3 ---
>  drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c | 3 ---
>  drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c     | 3 ---
>  drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c  | 3 ---
>  drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c     | 3 ---
>  drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c     | 3 ---
>  drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c     | 3 ---
>  8 files changed, 24 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> index e065f7e10cca..6468a765f3d1 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c
> @@ -231,9 +231,6 @@ static int panel_dpi_probe(struct platform_device *pdev)
>  	struct omap_dss_device *dssdev;
>  	int r;
>  
> -	if (!pdev->dev.of_node)
> -		return -ENODEV;
> -
>  	ddata = devm_kzalloc(&pdev->dev, sizeof(*ddata), GFP_KERNEL);
>  	if (ddata == NULL)
>  		return -ENOMEM;
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> index bdc0e8a3832d..aac14f399657 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
> @@ -1168,9 +1168,6 @@ static int dsicm_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, ddata);
>  	ddata->pdev = pdev;
>  
> -	if (!pdev->dev.of_node)
> -		return -ENODEV;
> -
>  	r = dsicm_probe_of(pdev);
>  	if (r)
>  		return r;
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> index 74d13969b9ca..b955aa615a5f 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-lgphilips-lb035q02.c
> @@ -268,9 +268,6 @@ static int lb035q02_panel_spi_probe(struct spi_device *spi)
>  
>  	ddata->spi = spi;
>  
> -	if (!spi->dev.of_node)
> -		return -ENODEV;
> -
>  	r = lb035q02_probe_of(spi);
>  	if (r)
>  		return r;
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c b/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
> index df8132d3b9c6..70fa5a04c00e 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-nec-nl8048hl11.c
> @@ -277,9 +277,6 @@ static int nec_8048_probe(struct spi_device *spi)
>  
>  	ddata->spi = spi;
>  
> -	if (!spi->dev.of_node)
> -		return -ENODEV;
> -
>  	r = nec_8048_probe_of(spi);
>  	if (r)
>  		return r;
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c b/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
> index 98d170aecaba..99048e430871 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-sharp-ls037v7dw01.c
> @@ -268,9 +268,6 @@ static int sharp_ls_probe(struct platform_device *pdev)
>  
>  	platform_set_drvdata(pdev, ddata);
>  
> -	if (!pdev->dev.of_node)
> -		return -ENODEV;
> -
>  	r = sharp_ls_probe_of(pdev);
>  	if (r)
>  		return r;
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c b/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c
> index 06d7d8362a73..cc5e9a68726a 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-sony-acx565akm.c
> @@ -720,9 +720,6 @@ static int acx565akm_probe(struct spi_device *spi)
>  
>  	dev_dbg(&spi->dev, "%s\n", __func__);
>  
> -	if (!spi->dev.of_node)
> -		return -ENODEV;
> -
>  	spi->mode = SPI_MODE_3;
>  
>  	ddata = devm_kzalloc(&spi->dev, sizeof(*ddata), GFP_KERNEL);
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
> index 0a38a0e8c925..34d8f42fefbe 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td028ttec1.c
> @@ -404,9 +404,6 @@ static int td028ttec1_panel_probe(struct spi_device *spi)
>  
>  	ddata->spi_dev = spi;
>  
> -	if (!spi->dev.of_node)
> -		return -ENODEV;
> -
>  	r = td028ttec1_probe_of(spi);
>  	if (r)
>  		return r;
> diff --git a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
> index ac4a6d4d134c..06fb5a995002 100644
> --- a/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
> +++ b/drivers/gpu/drm/omapdrm/displays/panel-tpo-td043mtea1.c
> @@ -509,9 +509,6 @@ static int tpo_td043_probe(struct spi_device *spi)
>  
>  	ddata->spi = spi;
>  
> -	if (!spi->dev.of_node)
> -		return -ENODEV;
> -
>  	r = tpo_td043_probe_of(spi);
>  	if (r)
>  		return r;
> -- 
> Regards,
> 
> Laurent Pinchart
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
dri-devel mailing list
dri-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux