On Thu, Oct 12, 2017 at 2:39 AM, Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxxxx> wrote: > Wei Yongjun <weiyongjun1@xxxxxxxxxx> writes: > >> In case of error, the function of_graph_get_remote_node() returns NULL >> pointer not ERR_PTR(). The IS_ERR() test in the return value check >> should be replaced with NULL test.. > > Looks good. > > Reviewed-by: Gabriel Krisman Bertazi <krisman@xxxxxxxxxxxxxxx> > FYI, I just noticed Dan Carpenter sent an identical patch last week "<20171005125751.jvtjms62vbtxuvak@mwanda> [PATCH] drm/kirin: Checking for IS_ERR() instead of NULL". I'll add my R-b there, since it was first. Sean > -- > Gabriel Krisman Bertazi _______________________________________________ dri-devel mailing list dri-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/dri-devel